search

cristianbote / hnpwa-vanilla

Hacker News PWA implemented using no framework just javascript
https://hnpwa-vanilla.firebaseapp.com/
MIT License
273 stars 30 forks source link

Update installation of HNPWA-vanilla documentation #11

Closed kresnasatya closed 6 years ago

kresnasatya commented 6 years ago

Hi Cristian, I just try update installation of HNPWA-vanilla documentation. You can try in local. If it runs well, please let me know. Thanks a lot.

cristianbote commented 6 years ago

Hey @satyakresna,

Thank you! 😄 This clears up the confusing parts of running it locally, for sure. I need to check something first, because I think you can do it via firebase-cli and don't need to have the python installed.

I'll get back to you. Thanks again!

kresnasatya commented 6 years ago

You're welcome Cristian. Nice to help the author and me how it works.

On Feb 12, 2018 2:46 PM, "Cristian Bote" notifications@github.com wrote:

Hey @satyakresna https://github.com/satyakresna,

Thank you! 😄 This clears up the confusing parts of running it locally, for sure. I need to check something first, because I think you can do it via firebase-cli and don't need to have the python installed.

I'll get back to you. Thanks again!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/cristianbote/hnpwa-vanilla/pull/11#issuecomment-364839779, or mute the thread https://github.com/notifications/unsubscribe-auth/AKlcMvBgKOxk25sRTtLIKTfVZOpcYryzks5tT95BgaJpZM4SA1x2 .

cristianbote commented 6 years ago

Hey @satyakresna, I just did a commit and added the npm run serve command. Would you be willing to update the wording on it? I'm gonna add some comments.

kresnasatya commented 6 years ago

Hi @cristianbote , just finished based on your request. Done, feel free to check. Thanks a lot.

cristianbote commented 6 years ago

Awesome @satyakresna!