search

cristianbote / hnpwa-vanilla

Hacker News PWA implemented using no framework just javascript
https://hnpwa-vanilla.firebaseapp.com/
MIT License
273 stars 30 forks source link

Firebase: not found #13

Closed mylastore closed 6 years ago

mylastore commented 6 years ago

not sure what this means: sh: 1: firebase: not found

cristianbote commented 6 years ago

Hey Oscar(@reachdevelopers),

Have you tried a npm install before running it? firebase should install after that. Please let me know if this fixed it.

Thanks for submitting!

mylastore commented 6 years ago

I did npm install

cristianbote commented 6 years ago

Uh, alrighty.

Do you have more info? Was this after a npm run command? What's your OS? Meanwhile, I'll look into it as well.

Again, thanks for reaching out!

mylastore commented 6 years ago

I download it again and same thing sh: 1: firebase: notfound also: Failed at the hnpwa-vanilla@2.1.3 serve script.

Linux Mint 17.3 node: v8.9.0 npm: 5.5.1

cristianbote commented 6 years ago

Hey @reachdevelopers you are indeed right. The dependency was pointing to the firebase sdk not the firebase-tools to be able to to serve it locally. A npm i should do it now.

Let me know if there are more issues.

Thanks for reaching gout!