cristianferrarig / font-awesome-middleman

Font-Awesome web fonts and stylesheets as a Middleman engine
MIT License
51 stars 16 forks source link

version 4.2.2 doesn't work with Middleman 3.3.x #14

Closed Nowaker closed 9 years ago

Nowaker commented 9 years ago

~> 3.0.0 means 3.0.x. Currently, Middleman is 3.3.x. font-awesome-middleman worked perfectly OK with M 3.3 (https://github.com/virtkick/virtkick-website), so I believe you meant ~> 3.0. :)

Bundler could not find compatible versions for gem "middleman-core":
  In Gemfile:
    font-awesome-middleman (~> 4.2.2) ruby depends on
      middleman-core (~> 3.0.0) ruby
    middleman (~> 3.3.0) ruby depends on
      middleman-core (3.3.0)
cristianferrarig commented 9 years ago

Fuck, and how I can update it without another release?

Thanks, a lot!

~> 3.0.0 means 3.0.x. Currently, Middleman is 3.3.x. font-awesome-middleman worked perfectly OK with M 3.3 ( https://github.com/virtkick/virtkick-website), so I believe you meant ~> 3.0. :)

Bundler could not find compatible versions for gem "middleman-core": In Gemfile: font-awesome-middleman (~> 4.2.2) ruby depends on middleman-core (~> 3.0.0) ruby middleman (~> 3.3.0) ruby depends on middleman-core (3.3.0)

— Reply to this email directly or view it on GitHub https://github.com/cristianferrarig/font-awesome-middleman/issues/14.

_ Cristian Ferrari

Nowaker commented 9 years ago

@cristianferrarig Doing another release isn't anything bad. :) Previously, it was >= 3.0 (OK but not perfect), so changing it to ~> 3.0 for good will make it perfect.

cristianferrarig commented 9 years ago

@Nowaker thanks. it's ready :-) https://github.com/cristianferrarig/font-awesome-middleman/releases/tag/v4.2.3