search

cristianpb / muse

Mopidy web client with Snapcast support
https://cristianpb.github.io/muse
Apache License 2.0
35 stars 6 forks source link

Support for older browsers (Mobile safari & chrome) #25

Open jgladch opened 3 years ago

jgladch commented 3 years ago

First off - great app. Thanks for sharing it with the world.

I have an older iPad I'd like to use as a little kiosk with Muse. It's stuck on iOS13 which does not seem to be supported by Svelte. (Both Chrome and Safari don't work)

Do you know what the best course of action might be? Do you think it's possible to add a polyfill into the build tooling that will allow for support of these older browsers? Or is the problem larger?

Muse is the nicest looking snapcast-supporting Mopidy frontend, and I'd like to use it, so if you could point me in the right direction I would appreciate it. I am happy to contribute, just thought I would check in first.

cristianpb commented 3 years ago

Hi @jgladch Thanks for your feedback. I haven't tested muse in a lot of browsers, but I think it's a good point.

I will try to add safari browser to babel in rollup.config.js, that should improve IOS support

jgladch commented 3 years ago

That's great, I really appreciate it. Happy to help test on my old iPad 👍.

cristianpb commented 3 years ago

Would you mind to test this url in your ipad: https://cristianpb.github.io/muse/ I'm trying an easyfix. I'm not sure that you would be able to connect to snapcast server, but you will be able to see if the html&js works.

jgladch commented 3 years ago

No change - menu items like "Now playing", "Search", "Browse", "Playlists" are clickable, but the hamburger menu in top right and player controls at the bottom are not clickable, same with "+" button on Playlists page.

cristianpb commented 3 years ago

I tried another fix using commonjs and babel. It should work in Safari 13 (at least opening the burger and the bottom navigation bar), I used an online test page. Would you mind to test ?

Screenshot_2020-12-23 Dashboard(2)

Do you know the version of Chrome that you have in IOS ?

jgladch commented 3 years ago

Is it the same url (cristianpb.github.io/muse)?

If that is correct, it still does not work with my iPad - same behavior, nothing but the text menu items is clickable.

Also, I realize I gave incorrect information. It turns out that my iPad is stuck on iOS 10.3 using Chrome version 71 and Safari version 10 (not iOS 13 like I originally thought). Apologies for that. What do you think?

cristianpb commented 3 years ago

Thanks for the information. It have more sense like that. I saw an error SyntaxError: Cannot declare a let variable twice 's' in Safari 10. I will try to solve that.

On the other hand, Chrome v71 should work :ok_hand:

jgladch commented 3 years ago

I appreciate your efforts! Chrome v71 on iOS 10.3 does not seem to work. Same issue - only text menu items are clickable. All icons (hamburger, player controls, buttons, etc) don't register clicks.