search

cristibalan / braid

Simple tool to help track vendor branches in a Git repository.
http://cristibalan.github.io/braid
MIT License
457 stars 64 forks source link

Test suite: Avoid changing the init.defaultBranch option globally. #103

Closed mattmccutchen closed 2 years ago

mattmccutchen commented 2 years ago

We shouldn't change the developer's global configuration without their consent (or documenting that the test suite should always be run in an isolated environment of some kind). See #37.

The full test suite passes on my Linux machine with Git 2.31. I also tested a few cases on Linux with Git 2.27 and Git 2.28 and on Windows with Git 2.34; hopefully that's good enough because the full test suite is slow on my Windows machine.

This PR shouldn't need a new Braid release because it only affects the test suite.

realityforge commented 2 years ago

Whoops - thanks. For some reason I thought we had already remapped the ser directory and thus this would not be an issue. Clearly not ;)