search

cristibalan / braid

Simple tool to help track vendor branches in a Git repository.
http://cristibalan.github.io/braid
MIT License
457 stars 64 forks source link

Show full stderr of failed commands + various maintenance 2024-08-02 #122

Closed mattmccutchen closed 3 months ago

mattmccutchen commented 3 months ago

This PR makes Braid show the full stderr of a ShellExecutionError when a command fails (fixing #90). I've bundled several less interesting maintenance changes into the same PR to reduce the overhead of running tests; the changes are still in separate commits for ease of review. Hopefully most of these are uncontroversial. I'm open to opinions about whether it's a good idea to add my testing checklist in its current form.

The tests pass on my Linux and Windows systems. @realityforge If you want to continue to support macOS, please run the tests and also check that the Sorbet static analyzer still works; bundle exec rake should take care of both of those things. You may have to update the RUBY_PLATFORM check in the Gemfile to match your current macOS environment.

It's been a long time and I had a bunch of challenges in life, but things finally aligned for me to finalize this relatively small change. I'm hoping I will keep the momentum and finish some bigger things soon, like the type annotations. Cheers!

realityforge commented 3 months ago

Thanks - tested it with MacOS Sonoma 14.5 .... and an older version of MacOS that I had about.

The change did require moving the version of ruby forward ... and bunch of new libraries for development dependencies. However this is not an issue as it seems that the ruby version shipped with MacOS (or maybe that I installed?) is absolutely ancient (2.6.10ish).

Thanks for the PR.

I am glad to see motion on this given I use it every day ;-)