search

cristinae / WikiTailor

Your à-la-carte in-domain corpora extraction tool from Wikipedia
1 stars 0 forks source link

mandatory unnecessary fields in some CLI #4

Open albarron opened 8 years ago

albarron commented 8 years ago

Most CLIs extend an abstract class which requires the .ini, year, and language, among other parameters. However, some classes, e.g., LuceneIndexerWT do not requiere year nor the ini. Now random inputs have to be given to these parameters.

They should not exist at all.

cristinae commented 8 years ago

Well, not exactly random, you can give true values. All the classes are called within an Xecutor pipeline either by the WT or the IR system. In this case, you initialise the full process with this minimum information, and the Xecutor shares with every class the parameters needed.

On the other hand it is true that every class can be used independently and has its own CLI. All of them extend a minimum CLI which wouldn't be necessary in some cases. However, this shouldn't a common use.

Feel free to modify the CLIs so that they do not extend the minimum one when there is not need for the basic parameters, but please, take care in keeping the outputs, the formats and the help information style coherently. All of this is controlled by WikipediaCliMinimum.java now.