Do not check that CSV files are rectangles

cristoper / gsheet

gsheet is a CLI tool (and Golang package) for piping csv data to and from Google Sheets

MIT License

83 stars 5 forks source link

Do not check that CSV files are rectangles #2

Closed matchaxnb closed 2 years ago

matchaxnb commented 2 years ago

Hey :)

Sometimes we want to upload CSV files that are not perfect rectangles. Like, some lines have 10 fields, some have 7.

By default Go checks against that. This small commits changes this. I think it's not the role of your tool to check whether our CSV makes sense.

WDYT?

Have fun :) happy hacking, super useful tool.

Matcha

cristoper commented 2 years ago

Thanks @matchaxnb... sorry I didn't notice this PR until now!

I agree that by default the tool should accept any shape of data. I can imagine some cases where it would be nice if an upload would fail for non-rectangular data... but if anyone ever needs that, we could expose it as an option with a --rectangular flag or similar.