search

crisu83 / yiistrap

Twitter Bootstrap for the Yii PHP framework.
http://www.getyiistrap.com
BSD 3-Clause "New" or "Revised" License
286 stars 176 forks source link

Multiple issues with TbTabs #123

Closed rlmckenney closed 11 years ago

rlmckenney commented 11 years ago

I don't know if this is an issue with the 2amigos fork or in this version. I posted this a week ago in 2amigos/yiiwheels, but there has been no response, so I am posting here.

Testing with simple example:

<?php $this->widget('bootstrap.widgets.TbTabs', array(
    'tabs' => array(
        array('label' => 'Billing Address',  'content' => '...', 'active' => true),
        array('label' => 'Shipping Address', 'content' => '...'),
       ),
)); ?>

Results in a Fatal error on call to TbHtml::tabbable It is defined as a protected function and should be public.

If I change TbHtml::tabbable to be a public function, then the CHtml::tag call fails with:

htmlspecialchars() expects parameter 1 to be string, array given

From the stack trace:

CHtml::tag("li", array("itemOptions" => array(), "class" => "active"), "<a data-toggle="tab" tabindex="-1" href="#tab_1">Billing Address...", true)

I am running 2maigos/Yiistrap 1.0.1 and Wheels 1.0.3

crisu83 commented 11 years ago

I just checked and that visibility issue that you mentioned has been fixed in origin a long time ago. The problem is that Yiistrap has evolved quite a bit since the 2amigos fork was made and they haven't pulled the latest changes.