search

crisu83 / yiistrap

Twitter Bootstrap for the Yii PHP framework.
http://www.getyiistrap.com
BSD 3-Clause "New" or "Revised" License
286 stars 176 forks source link

Pass iconOptions in TbHtml::menu() to icon() function #269

Closed Residentfoul closed 10 years ago

Residentfoul commented 10 years ago

As stated in the title, the iconOptions are not passed to the icon() function in the menu function of TbHtml. Yet this is required for setting icon colors of navBars.

The following change in the menu() function :

            //added $options parameter in icon() call to allow for icon coloration
            if (!empty($icon)) {
                $label = self::icon($icon,$options) . ' ' . $label;
            }

Not sure whether i chose the right branches for my pull request though.

Thanks for the awesome work guys.

crisu83 commented 10 years ago

Thanks for this!

crisu83 commented 10 years ago

Oh and please do the PRs to the develop branch. Thanks!