crisward / dokku-clone

a dokku plugin for building an app from a cloned git repo
48 stars 9 forks source link

Allow to pass port to clone:allow command #18

Open weyert opened 6 years ago

weyert commented 6 years ago

If you are running SSH on a different port then 22 this command would fail. I have added the optional argument to pass the port it will fallback to 22 when not given

crisward commented 4 years ago

Looks good though, wondering why this hasn't been reviewed / commented on

Usual reason, not something I need so didn't get round to testing / merging.

To manually test this kind of thing feels like it'd take an age

I mean I could just blindly merge it but that's bound to break the code in a difficult to predict way. I'm not a bash guru or anything so may have missed something.

Another solution to use a different port is to add something to your ~/.ssh/config file eg

Host git.yourhost.com
    Port 2020

Though I can see why it'd be easier to do this on the cli each time.