search

crisward / dokku-clone

a dokku plugin for building an app from a cloned git repo
48 stars 9 forks source link

Add --no-restart to clone comand #19

Open decentral1se opened 4 years ago

decentral1se commented 4 years ago

We can avoid the following:

ps_rebuild "$APP"

This is useful for doing Ansible deployments where you want to control exactly at which point the app is deployed and not have it come up during some other configuration command.

decentral1se commented 4 years ago

Please see https://github.com/crisward/dokku-clone/pull/21.

crisward commented 4 years ago

Thanks for the suggestion and having a go, and more importantly testing. I'll leave this open, but I can't promise I'll get chance to look at it any time soon.

ltalirz commented 3 years ago

I have a related request, which is: could we add a flag that makes dokku clone a no-op, if the git clone operation leaves the git checkout unchanged?

I notice that, currently, running dokku clone will rebuild the docker image and recreate the docker container even if the source code of the app hasn't changed at all.

P.S. If there was a way to make dokku clone a no-op in this case, it would simplify the implementation of the dokku_clone ansible module, since the module could then simply run dokku clone and rely on its internal logic to check whether anything needs to be done.