search

criteo-cookbooks / nssm

Chef cookbook to install the Non-Sucking Service Manager
http://nssm.cc
MIT License
13 stars 15 forks source link

params is deprecated #8

Closed ajrkerr closed 7 years ago

ajrkerr commented 7 years ago

Getting this warning message when using nssm. Looks like params will no longer be a valid parameter name for a resource.

       Deprecated features used!
         Property `params` of resource `nssm` overwrites an existing method. Please use a different property name. This will raise an exception in Chef 13. at 1 location:
dhoer commented 7 years ago

A PR with params renamed to something else would be welcome! I see that args is already used.

dhoer commented 7 years ago

I wonder if set is a valid attribute name or maybe commands?

ajrkerr commented 7 years ago

Could always spell out parameters too. I'll put together a PR. I'm also looking at solving the idempotency issue in the other ticket as well.

Love this cookbook btw. Saved my bacon while trying to install consul-template as a service.

dhoer commented 7 years ago

Parameters would be fine. Thanks for the kudos!

dhoer commented 7 years ago

Released v3.0.0

philipdouglas commented 7 years ago

I can't work out what happened, but this change seems to have gone missing in v3.0.0.

The master version of the resource still has params (https://github.com/dhoer/chef-nssm/blob/master/resources/default.rb#L7) and that's what I'm seeing in the source when I download 3.0.0 from the supermarket.

dhoer commented 7 years ago

Looks like merge didn't go so well.

dhoer commented 7 years ago

I will try to get this back in

dhoer commented 7 years ago

v3.0.1 fixes this