search

criteo-cookbooks / winrm-config

Windows Remoting Server
Apache License 2.0
5 stars 2 forks source link

Add run_as_user to service resource to work on Chef 14 #15

Closed jugatsu closed 5 years ago

jugatsu commented 5 years ago

On Chef 14 windows_service resource defaults to LocalSystem as a user account. So explicitly set user parameter to bypass user mismatch as WinRM uses NetworkService account.

Signed-off-by: Anton Kvashenkin anton.jugatsu@gmail.com

Closes #14

jugatsu commented 5 years ago

@Annih Can you review please.

jugatsu commented 5 years ago

Done rebase.

Annih commented 5 years ago

Many thanks for your PR @jugatsu I'll release ASAP

jugatsu commented 5 years ago

@Annih Could you release new version please? Or should I make PR with version bump and CHANGELOG?

jugatsu commented 5 years ago

@Annih Any updates?

Annih commented 5 years ago

Hello @jugatsu I'll do my best, but as you said the run_as_user has been introduced in version 12.6 and this cookbook was still supporting Chef 12.0, I'm trying to decide whether to just drop the support or not.

Anyway, I'll do a release before wednesday, is it OK?

jugatsu commented 5 years ago

@Annih Yes, it's ok.

Judging by this commit https://github.com/chef/chef/commit/be28ba90bde1fe0240f313151e3d564ce57e8b29, run_as_user was added to 12.1 version, as a result you should'n drop support as in metadata:

chef_version     '>= 12.1' if respond_to?(:chef_version)
jugatsu commented 5 years ago

@Annih Yes, it's ok.

Judging by this commit https://github.com/chef/chef/commit/be28ba90bde1fe0240f313151e3d564ce57e8b29, run_as_user was added to 12.1 version, as a result you should'n drop support as in metadata:

chef_version     '>= 12.1' if respond_to?(:chef_version)
jugatsu commented 5 years ago

@Annih Yes, it's ok.

Judging by this commit https://github.com/chef/chef/commit/be28ba90bde1fe0240f313151e3d564ce57e8b29, run_as_user was added to 12.1 version, as a result you should'n drop support as in metadata:


chef_version     '>= 12.1' if respond_to?(:chef_version)
jugatsu commented 5 years ago

@Annih Yes, it's ok.

Judging by this commit https://github.com/chef/chef/commit/be28ba90bde1fe0240f313151e3d564ce57e8b29, run_as_user was added to 12.1 version, as a result you should'n drop support as in metadata:


chef_version     '>= 12.1' if respond_to?(:chef_version)
jugatsu commented 5 years ago

@Annih Yes, it's ok.

Judging by this commit https://github.com/chef/chef/commit/be28ba90bde1fe0240f313151e3d564ce57e8b29, run_as_user was added to 12.1 version, as a result you should'n drop support as in metadata:


chef_version     '>= 12.1' if respond_to?(:chef_version)
jugatsu commented 5 years ago

@Annih Yes, it's ok.

Judging by this commit https://github.com/chef/chef/commit/be28ba90bde1fe0240f313151e3d564ce57e8b29, run_as_user was added to 12.1 version, as a result you should'n drop support as in metadata:


chef_version     '>= 12.1' if respond_to?(:chef_version)
jugatsu commented 5 years ago

@Annih Yes, it's ok.

jugatsu commented 5 years ago

@Annih Yes, it's ok.

jugatsu commented 5 years ago

Github comments is going crazy :)

Annih commented 5 years ago

@jugatsu I just released the new version. We still have other incompatibilities with Chef 13+ but I'll fix them in another release. Many thanks for your great contribution!