search

criteo-cookbooks / wsus-server

Chef Cookbook to install and configure server for Windows Server Update Services (WSUS)
Apache License 2.0
15 stars 14 forks source link

fix in order to work with chef-client 12.11.18 (x64) and use helper … #19

Closed jmunnik closed 8 years ago

jmunnik commented 8 years ago

Hi,

Can you have a look at the fix as it's solving the issue below and compatible with older clients.

Regards, Jos

Failure with chef 12.11.18

Generated at 2016-07-11 23:09:22 +0200 Mixlib::ShellOut::ShellCommandFailed: wsus_server_configuration[Wsus server configuration](wsus-server::configure line 27) had an error: Mixlib::ShellOut::ShellCommandFailed: Expected process to exit with [0], but received '1' ---- Begin output of %windir%/SysNative/WindowsPowershell/v1.0/PowerShell.exe -NoLogo -NonInteractive -NoProfile -ExecutionPolicy RemoteSigned -InputFormat None -EncodedCommand BLA ---- STDOUT: STDERR: The system cannot find the path specified. ---- End output of %windir%/SysNative/WindowsPowershell/v1.0/PowerShell.exe -NoLogo -NonInteractive -NoProfile -ExecutionPolicy RemoteSigned -InputFormat None -EncodedCommand BLA ---- Ran %windir%/SysNative/WindowsPowershell/v1.0/PowerShell.exe -NoLogo -NonInteractive -NoProfile -ExecutionPolicy RemoteSigned -InputFormat None -EncodedCommand BLA returned 1 c:/opscode/chef/embedded/lib/ruby/gems/2.1.0/gems/mixlib-shellout-2.2.6-universal-mingw32/lib/mixlib/shellout.rb:289:in invalid!' c:/opscode/chef/embedded/lib/ruby/gems/2.1.0/gems/mixlib-shellout-2.2.6-universal-mingw32/lib/mixlib/shellout.rb:276:inerror!' C:/chef/cache/cookbooks/wsus-server/libraries/base_provider.rb:74:in powershell_out64' C:/chef/cache/cookbooks/wsus-server/providers/configuration.rb:51:inload_current_resource' c:/opscode/chef/embedded/lib/ruby/gems/2.1.0/gems/chef-12.11.18-universal-mingw32/lib/chef/provider.rb:128:in run_action' c:/opscode/chef/embedded/lib/ruby/gems/2.1.0/gems/chef-12.11.18-universal-mingw32/lib/chef/resource.rb:591:inrun_action'

With applied change:

Recipe: wsus-server::synchronize

Annih commented 8 years ago

Seems OK to me, I'll check your why your test are failing.

jmunnik commented 8 years ago

Hi Baptiste Courtois,

Everything allright ? I've reverted the version number so I hope you van have a look and release this version so that I'm able to make an artifact out of it and freeze it at our end.

Regards, Jos

Annih commented 8 years ago

Thanks @jmunnik, I rebased and squashed your changes in master branch. I'll release soon :)