Adding a Pytorch version

criteo-research / paiss_deeprl

Apache License 2.0

22 stars 9 forks source link

Adding a Pytorch version #4

Closed alexis-jacq closed 6 years ago

alexis-jacq commented 6 years ago

Please find a Pytorch version of the reinforcement learning tutorial, if some of us want to try this library for RL. The structure is exactly the same, just some changes to build the models. I provide a suggestion of solution that solves the different exercise steps of the tutorial.

oddskool commented 6 years ago

Thank you for this version :)

If you want to merge it please

remove all execution traces from the exercises notebook
remove your solution notebook

alexis-jacq commented 6 years ago

I've removed execution traces and the solution notebook in this last commit.

oddskool commented 6 years ago

It seems the recommended way to install pytorch should be via: conda install pytorch torchvision -c pytorch I'm unable to make it work if I install using pip on OSX :( Which way did you install it ?

oddskool commented 6 years ago

I tested this version and everything seems fine. We could merge it after we figure out the recommended setup instructions for pytorch.

alexis-jacq commented 6 years ago

On the main page of Pytorch, they say "Anaconda is our recommended package manager", I think that's the most stable way to install it.