criteo-research / paiss_deeprl

Apache License 2.0
22 stars 9 forks source link

pytorch tutorial fixed position missing torch.manual_seed() #7

Open omry opened 6 years ago

omry commented 6 years ago

in pytorch tutorial, block : Let's try with a fixed initial position

does not actually fixes the position, torch manual seed should also be used.

agent = DQNAgent(env.observation_space, env.action_space)
seed = 10
torch.manual_seed(seed)
env.run(agent, episodes=300, seed=seed)
oddskool commented 6 years ago

ok. do you mind opening a pull-request for that ?