search

criteo / JVips

Java wrapper for libvips using JNI.
Apache License 2.0
72 stars 41 forks source link

Add all supported image formats #117

Open geekdenz opened 2 years ago

geekdenz commented 2 years ago

Vips supports at least also ".tif":

https://github.com/libvips/libvips/blob/v8.9.1/test/test-suite/test_foreign.py#L304-L317

Could you support that as well? Should be a trivial change here:

https://github.com/criteo/JVips/blob/master/src/main/java/com/criteo/vips/enums/VipsImageFormat.java#L24

Add:

TIF(".tif"),

I could do a PR but that might take me longer than for you to do the change and supply a new version.

Many thanks for this awesome wrapper for this amazing library!

dbouron commented 2 years ago

Hello @geekdenz,

I just answered in your PR, this is not trivial like adding the enum value. I provided more explanations in comment .

If I have free time this week end, I will have a look :)