criteo / babar

Profiler for large-scale distributed java applications (Spark, Scalding, MapReduce, Hive,...) on YARN.
Apache License 2.0
125 stars 29 forks source link

Add option to limit the depth of the JSON object #3

Closed MaximeKestemont closed 6 years ago

MaximeKestemont commented 6 years ago

In some context, the call stack can grow very deep. The resulting JSON object cannot be parsed, with a RangeError: Maximum call stack size exceeded. The browser is then unable to render any of the generated html files.

Proposed fix : A new option that set a threshold on the depth of the methods. Any method that would be deeper in the call stack than this threshold will be filtered out.

Potential improvement : Set this behaviour by default (with a given threshold that still needs to be figured out), and give an option to disable it/change the threshold.