Change glob_metrics() to return metric metadata

criteo / biggraphite

Simple Scalable Time Series Database

Apache License 2.0

130 stars 35 forks source link

Change glob_metrics() to return metric metadata #459

Closed adericbourg closed 6 years ago

coveralls commented 6 years ago

Coverage increased (+0.3%) to 81.971% when pulling a1d767aa64ec0ca5c04478e43bfcd678deec8930 on adericbourg:glob_metrics into 2a896d5b1694e5e5f2066606ad1e8b491fa2b5e2 on criteo:master.

adericbourg commented 6 years ago

:ok_hand:

geobeau commented 6 years ago

Did you perform the test with success?

adericbourg commented 6 years ago

@geobeau Yes, we ran some locally without noticeable issue.

Performance were not so good. It was unrelated to this change but was fixed anyway in a1d767a.

iksaif commented 6 years ago

After deployment can you post a latency graph here ? I'm curious :)

adericbourg commented 6 years ago

@iksaif If it does not break the graph, sure! :)