search

criteo / biggraphite

Simple Scalable Time Series Database
Apache License 2.0
129 stars 36 forks source link

Some bgutils commands were print python objects instead of string representation #493

Closed adriengentil closed 5 years ago

adriengentil commented 5 years ago

For example with bgutil, the display is broken.

$ bg/bin/bgutil --loglevel=DEBUG --storage_dir=/opt/graphite/storage --driver=cassandra  --cassandra_contact_points=... --cassandra_contact_points_metadata=... --cassandra_concurrent_connections=50 list --graphite <query>
2018-12-14 16:34:40,909 [DEBUG] biggraphite.drivers.cassandra: [<biggraphite.drivers.cassandra._CassandraExecutionRequest object at 0x7f1e8c1edf90>, <biggraphite.drivers.cassandra._CassandraExecutionRequest object at 0x7f1e8c1ede90>, <biggraphite.drivers.cassandra._CassandraExecutionRequest object at 0x7f1e8c1edd50>, <biggraphite.drivers.cassandra._CassandraExecutionRequest object at 0x7f1e8c1eddd0>, <biggraphite.drivers.cassandra._CassandraExecutionRequest object at 0x7f1e8c1edd10>, <biggraphite.drivers.cassandra._CassandraExecutionRequest object at 0x7f1e8c1edc50>, <biggraphite.drivers.cassandra._CassandraExecutionRequest object at 0x7f1e8c1edcd0>, <biggraphite.drivers.cassandra._CassandraExecutionRequest object at 0x7f1e8c1eda50>]
d <biggraphite.glob_utils.GlobDirectoryResult instance at 0x7f1e8de7c8c0>

I implemented str on _CassandraExecutionRequest and GlobDirectoryResult in order to get the object's string.

I also removed the variable GlobDirectoryResult.value which seem to not be used in BG.

coveralls commented 5 years ago

Coverage Status

Coverage decreased (-0.02%) to 82.28% when pulling c83fcd79ae2603e5b328f5facf73291aa3d7aa94 on adriengentil:fix-bgutil-print into 7ccfe8f03f09a2be9ebf89aaa3bf06376ac6a23b on criteo:master.