fix accessor cache on python 3.x

criteo / biggraphite

Simple Scalable Time Series Database

Apache License 2.0

130 stars 36 forks source link

fix accessor cache on python 3.x #498

Closed Roguelazer closed 5 years ago

Roguelazer commented 5 years ago

This is the only issue I've found so far running on Python 3.6 instead of Python 2.7 (an upgrade I'm trying to do now since Python 2.7 EOLs this year). Applying this patch results in correct rendering in graphite and correct ingestion through bg-carbon-cache.

coveralls commented 5 years ago

Coverage decreased (-0.02%) to 81.921% when pulling 117428ced7fc9737c38374d0b214a1c85435765a on EasyPost:fix_hashing into 683ed9cd388fbcc94d19a6aeaddb90916a6fc715 on criteo:master.

coveralls commented 5 years ago

Coverage decreased (-0.02%) to 81.921% when pulling 117428ced7fc9737c38374d0b214a1c85435765a on EasyPost:fix_hashing into 683ed9cd388fbcc94d19a6aeaddb90916a6fc715 on criteo:master.

coveralls commented 5 years ago

Coverage increased (+0.04%) to 81.894% when pulling 75cdf32b5b3ef954c81f806ac9b15a16113099b2 on EasyPost:fix_hashing into 53e2edfbd5cd539eb1f3a8b3c7145a9d7a713276 on criteo:master.

iksaif commented 5 years ago

Could you copy the backtrace if you still have it ? thanks !

adriengentil commented 5 years ago

Thanks for your contribution ! Can you rebase before we merge ?