criteo / cluster-pack

A library on top of either pex or conda-pack to make your Python code easily available on a cluster
Apache License 2.0
45 stars 21 forks source link

Correct error raising when packaging pex #88

Closed alois-bissuel closed 2 years ago

alois-bissuel commented 2 years ago

This commit enables to have the pex packaging error directly in the notebook, removing the need to run the pex command if something goes awry. It looks like there is a bug in subprocess.run when checking is activated, as the stderr is then the error in Python itself (on Linux at least). Going in two steps solves the problem.