search

criteo / consul-templaterb

consul-template-like with erb (ruby) template expressiveness
Apache License 2.0
77 stars 28 forks source link

inactivity_timeout for the vault endpoint isn't configurable/too short #76

Open steveberryman opened 3 years ago

steveberryman commented 3 years ago

We run a somewhat unconventional consul/vault setup, in that our clusters are far away from some of our servers and thus latency is pretty poor. With the hard-coded inactivity_timeout for vault of 1s here

https://github.com/criteo/consul-templaterb/blob/fa13ad2143726dad0fbdc32e0e4c15affb7c370d/lib/consul/async/vault_endpoint.rb#L234

consul-templaterb often times out during a run for some keys. I confirmed that increasing this to a longer time fixes the issue. Potentially somewhat of a niche request, but making this configurable would allow increase the timeout in cases where vault was a stupid distance away from the host consul-templaterb was running on.

pierresouchay commented 3 years ago

@steveberryman Indeed, this is pretty hardcoded... there are lots of places where we borrow parameters from the command line, would you be interested with providing a patch?

steveberryman commented 3 years ago

Yeah I’m sure I could do that :) On 20 Aug 2021, 16:25 +0100, Pierre Souchay @.***>, wrote:

@steveberryman Indeed, this is pretty hardcoded... there are lots of places where we borrow parameters from the command line, would you be interested with providing a patch? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.