search

criteo / graphite-remote-adapter

Fully featured graphite remote adapter for Prometheus
Apache License 2.0
38 stars 25 forks source link

Adding "exclude_labels" rule option #63

Closed Lucas-C closed 5 years ago

Lucas-C commented 5 years ago

This new option allows to exclude some labels, for example verbose ones, from the generated Graphite key path

uepoch commented 5 years ago

Hello @Lucas-C, thanks for your PR ! Sorry for the long latency :(

I feel that altering the metric received should be done on prometheus's side, as it has a better engine for relabeling, which is basically what you want to achieve I'm not totally against it, but I still think this should be enforced at the prometheus, as you might get into a state where you generate duplicated metrics without knowing it

Do you have a specific use case in mind where it's not possible to do it on prom side ?

Lucas-C commented 5 years ago

I do not have a specific use case. I juste discovered how it can be done in Prometheus : https://medium.com/quiq-blog/prometheus-relabeling-tricks-6ae62c56cbda I'm going to try this then. I understand if you don't want to include it in graphite-remote-adapter