Closed csminticiuc closed 1 year ago
A general note on commit structure. I see that you're applying the fixup strategy in your PR. I would recommend you to rather rebase so that the commit history stay cleaned. I see that it is not explicitly written in the iOS repository, although it is implicitly in the Android one: https://github.com/criteo/android-publisher-sdk/blob/main/CONTRIBUTING.md#pull-requests
Generally, we target that each commit should:
As a side effect, applying such rules is helping when reverting.
Changes:
childDirectedTreatment
to Criteo singleton.childDirectedTreatment
is actually stored in theBidManager
class, notCriteo
class.childDirectedTreatment
is then passed fromBidManager
toCR_ApiHandler
and then toCR_BidRequestSerializer
and translated intoregs.coppa
in the body request parameters.CR_ApiQueryKeys
to not be optional when used in Swift.childDirectedTreatment
property in theCriteoAdViewer
project application.Jira ticket: DPP-4090