criteo / ios-publisher-sdk

Criteo Publisher SDK for iOS
https://publisherdocs.criteotilt.com/app/ios/get-started/
Apache License 2.0
10 stars 7 forks source link

DPP-4090 Add COPPA support to iOS Publisher SDK #244

Closed csminticiuc closed 1 year ago

csminticiuc commented 2 years ago

Changes:

Jira ticket: DPP-4090

Before After
coppa_before coppa_after
coppa_ui_before coppa_ui_after
TurpIF commented 2 years ago

A general note on commit structure. I see that you're applying the fixup strategy in your PR. I would recommend you to rather rebase so that the commit history stay cleaned. I see that it is not explicitly written in the iOS repository, although it is implicitly in the Android one: https://github.com/criteo/android-publisher-sdk/blob/main/CONTRIBUTING.md#pull-requests

Generally, we target that each commit should:

As a side effect, applying such rules is helping when reverting.