Feature consumer group events

criteo / kafka-sharp

A C# Kafka driver

Apache License 2.0

110 stars 44 forks source link

Closed divan-9 closed 7 years ago

divan-9 commented 7 years ago

Fixing shameful untested misbehavior :) Events were not actually work at all anywhere except ConsumerRouter. I added some tests to be sure

sdanzan commented 7 years ago

Test "RaisesPartitionsRevokedEvent" is failing.

divan-9 commented 7 years ago

That's TestConsumer_ConsumerGroupHeartbeatErrors . Maybe 20ms of sleeping wasn't enough...

sdanzan commented 7 years ago

Mmm, the test consistently fails now, it's not just flaky. Something is broken.

sdanzan commented 7 years ago

Or travis has problems, because it just passed :)