criteo / kerberos-docker

Run kerberos environment in docker containers
Apache License 2.0
127 stars 50 forks source link

Added validation for virtualenv before running Make #1

Closed strider4560 closed 6 years ago

strider4560 commented 6 years ago

When I ran this, I did not have virtualenv installed. The make file attempted to run which caused the process to fail after the Makefile had removed necessary files, requiring me to delete the folder, re-clone, and re-execute the make command.

glegoux commented 6 years ago

Just one make install again should work, but it is not clear, feel free to give some other feedbacks, I merge that, thx for patch.