criteo / py-consul

Python client for Consul (http://www.consul.io/)
MIT License
42 stars 14 forks source link

Missing tagged_addresses in service register #83

Open mskillx opened 2 weeks ago

mskillx commented 2 weeks ago

Missing tagged_addresses in Service registration


class Service:
        def __init__(self, agent):
            self.agent = agent

        def register(
            self,
            name,
            service_id=None,
            address=None,
            port=None,
            tags=None,
            check=None,
            token=None,
            meta=None,
            weights=None,
            tagged_addresses= dict | None, <<<<<<-----------------
            # *deprecated* use check parameter
            script=None,
            interval=None,
            ttl=None,
            http=None,
            timeout=None,
            enable_tag_override=False,
            extra_checks=None,
        ):  ...
if tagged_addresses:
                payload["tagged_addresses"] = tagged_addresses```
cpaillet commented 1 week ago

Can you create a PR ? thanks