search

criticalmanufacturing / cli

Critical Manufacturing Projects Command Line Tool
https://criticalmanufacturing.github.io/cli/
BSD 3-Clause "New" or "Revised" License
10 stars 22 forks source link

feat: ignore custom dlls when packing biz #322

Closed oliveriosousa closed 4 days ago

oliveriosousa commented 11 months ago

Description

This PR adds logic to ignore custom dlls when packing business solution.

Open topics

Should we add this logic in here? If yes, should we add any kind of guard for projects that really need to deliver custom dlls?

Tests

Still need to test on the pipeline if is being ignore when deploying.

Tested manually: After running the packing command, the manifest has the following default steps:

  <steps>
    <step type="Generic" onExecute="$(Agent.Root)/agent/scripts/stop_host.ps1" />
    <step type="DeployFiles" contentPath="**/!(Cmf.Custom.*.BusinessObjects.*.dll)" />
    <step type="Generic" onExecute="$(Agent.Root)/agent/scripts/start_host.ps1" />
  </steps>
m-s- commented 8 months ago

@oliveriosousa should we drop this, or is this still something impacting your workflow?

m-s- commented 4 days ago

I'll take the radio silence as a yes, if this is still something you want open please a new PR