use the same variable name for PackageId/PackageName on Core project - Githubissues

criticalmanufacturing / cli

Critical Manufacturing Projects Command Line Tool

https://criticalmanufacturing.github.io/cli/

BSD 3-Clause "New" or "Revised" License

10 stars 22 forks source link

use the same variable name for PackageId/PackageName on Core project #347

Open joaoopereira opened 8 months ago

joaoopereira commented 8 months ago

We should use always the same variable name on core project: https://github.com/criticalmanufacturing/cli/blob/df7956a26293e6698c17265aaa90102c8805f81f/core/StartupModule.cs#L23 vs https://github.com/criticalmanufacturing/cli/blob/df7956a26293e6698c17265aaa90102c8805f81f/core/Objects/ExecutionContext.cs#L50

IMO we should use PackageId