search

criticalmaps / criticalmaps-android

🤖 Critical Maps Android App
http://criticalmaps.net
Apache License 2.0
138 stars 27 forks source link

use fused location provider #116

Closed stephanlindauer closed 5 years ago

stephanlindauer commented 8 years ago

if this conflicts with the f-droid policy, we'll have to think of a way to make it work for two falvors.

stephanlindauer commented 8 years ago

https://developers.google.com/android/reference/com/google/android/gms/location/FusedLocationProviderApi

cbalster commented 8 years ago

Since we're making constant use of the location gps and network providers, I don't think there is much potential for saving power by using the fused location provider.

ligi commented 8 years ago

It could help in tunnels ;-)

cbalster commented 8 years ago

Afaik FLP doesn't do any extrapolation either.

stephanlindauer commented 8 years ago

what are the advandages of using fused then?

cbalster commented 8 years ago

It abstracts away the difference between of GPS and network providers, handling of accuracy and timestamps, frequency of updates etc. You only specify an abstract requirement for your location needs and the rest is taken care of. Besides making things a little easier it also allows the system to optimize for battery usage by batching location updates etc. Sinve we're polling in really short intervals and basically want the highest precision we can get, we won't get any benefits from that. Since we already have sufficient quality filtering of location fixes in place, I don't see any need for introducing a dependency to play services.

On Sep 30, 2016 9:10 AM, "stephan lindauer" notifications@github.com wrote:

what are the advandages of using fused then?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/criticalmaps/criticalmaps-android/issues/116#issuecomment-250675371, or mute the thread https://github.com/notifications/unsubscribe-auth/AI1mmxfR5xZSMobQ0nDqj3pmGvnCJxS_ks5qvLXGgaJpZM4GeK-j .

stephanlindauer commented 8 years ago

okay i see. can we close this issue then?

cbalster commented 8 years ago

From my side, yes ;)

ligi commented 8 years ago

ack - but I would not say 100% no to play-services as a flavor ( but it should always give a play-services free flavor e.g. for fdroid ) - I think a day/night mode would be great for the app and that would be good with the new styleable maps from play-services

stephanlindauer commented 5 years ago

@cbalster this can be closed, am i right?

cbalster commented 5 years ago

Yep.

On Fri, 19 Jul 2019, 22:03 stephan lindauer notifications@github.com wrote:

@cbalster https://github.com/cbalster this can be closed, am i right?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/criticalmaps/criticalmaps-android/issues/116?email_source=notifications&email_token=ACGWNG2MXM2GPADTZY5IO5TQAIMYJA5CNFSM4BTYV6R2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2MUABQ#issuecomment-513359878, or mute the thread https://github.com/notifications/unsubscribe-auth/ACGWNG6ZJ4UEULVKNT4JBM3QAIMYJANCNFSM4BTYV6RQ .