Translations

[cbalster]

second commit only adds the strings to simplify updating the translations later

[ligi]

ack @ 28d1831 regarding the missing translations I would only add when we really have a translation - not duplicating the en version as this is used as fallback anyway

[cbalster]

I added the English versions to make it easier for the people doing the translations to identify the missing strings. I planned to @ them in an issue after this is merged.

On Sep 11, 2016 4:58 PM, "ligi" notifications@github.com wrote:

ack @ 28d1831 https://github.com/criticalmaps/criticalmaps-android/commit/28d1831c5a39b18cac41ae986787f7e5f8324825 regarding the missing translations I would only add when we really have a translation - not duplicating the en version as this is used as fallback anyway

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/criticalmaps/criticalmaps-android/pull/178#issuecomment-246184626, or mute the thread https://github.com/notifications/unsubscribe-auth/AI1mmxJM5rzRgpGtsfz58a-X-coUnPUMks5qpBcigaJpZM4J5-3G .

[ligi]

I would suggest we use a translation management service like transifex for this.

[cbalster]

I know and I think we already planned to set it up but no one ever did ;)

On Sep 11, 2016 6:09 PM, "ligi" notifications@github.com wrote:

I would suggest we use a translation management service like transifex for this.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/criticalmaps/criticalmaps-android/pull/178#issuecomment-246188267, or mute the thread https://github.com/notifications/unsubscribe-auth/AI1mm-CXyn5Dq5YwgShaJBpG0emCWOmnks5qpCfFgaJpZM4J5-3G .

[ligi]

I ( think *1 ) I can set it up if wanted @stephanlindauer - would really prefer the placeholders to be there than rather in the xml's

*1 - have to check if this is possible as contributor to a project or if you have to be owner

[stephanlindauer]

@cbalster i agree with ligi to not add english strings to languages where we don't have a translation for yet. in case it's missing it will fall back to english anyway and in android studio its easier to spot missing translation if we don't add them. however +1 on the first commit. @ligi i tried transifex but i wasn't properly convinced due to the fact the there was still some manual labour involved to pull in the strings. also i think its nice to have everything in one place (github) without external dependencies. but i don't have such a strong opinion in this. if you want to set it up, juts go ahead. i will supply you with the necessary rights.

[ligi]

@stephanlindauer there is a tool called tx - so usually this is the workflow then:

tx pull git commit -a -m "Update translations"

[stephanlindauer]

@ligi https://www.transifex.com/criticalmaps/critical-maps/

[stephanlindauer]

let's maybe take this discussion to https://github.com/criticalmaps/criticalmaps-android/issues/180

regarding this pr: i would merge if the second commit would be reverted.

[cbalster]

second commit removed and rebased on top of develop