criticalmaps / criticalmaps-android

🤖 Critical Maps Android App
http://criticalmaps.net
Apache License 2.0
137 stars 27 forks source link

Add transifex config #181

Closed ligi closed 8 years ago

ligi commented 8 years ago

Add transifex config ( should work - not yet sure about the dash (-) but I cannot check as this has to be done by the project owner. @stephanlindauer just get the tx-tool and then try a "tx pull"

stephanlindauer commented 8 years ago
stephan@stephan-XPS-15-9550:~/workspace/criticalmaps-android$ tx pull
Done.
stephan@stephan-XPS-15-9550:~/workspace/criticalmaps-android$ git diff
diff --git a/.tx/config b/.tx/config
index 385b5ec..f1603f2 100644
--- a/.tx/config
+++ b/.tx/config
@@ -1,7 +1,3 @@
 [main]
 host = https://www.transifex.com

-[critical-maps]
-file_filter = ap/src/main/res/values-<lang>/strings.xml
-source_file = ap/src/main/res/values/strings.xml
-source_lang = en
ligi commented 8 years ago

why did you remove this:

-[critical-maps] -file_filter = ap/src/main/res/values-/strings.xml -source_file = ap/src/main/res/values/strings.xml -source_lang = en

this is needed for the mapping

ligi commented 8 years ago

but I just see - must be app not ap - will push an update

cbalster commented 8 years ago

If I understood https://github.com/travis-ci/travis-ci/issues/3241 correctly, we can ignore the /push error. Is this working otherwise now?

stephanlindauer commented 8 years ago
stephan@stephan-XPS-15-9550:~/workspace/criticalmaps-android$ tx pull
ValueError: need more than 1 value to unpack

don't know what the problem is. will have a deeper look later.

stephanlindauer commented 8 years ago

still won't work my ~/.transifexrc looks like this (except the pw)

[https://www.transifex.com]
hostname = https://www.transifex.com
password = XXXXXXXXXXXXX
token = 
username = stephanlindauer

@ligi, can i add you as an admin to the transifex project?

ligi commented 8 years ago

hm my ( working ) transifexrc looks the same - I can try when you make me admin

stephanlindauer commented 8 years ago

whats your transifex username?

ligi commented 8 years ago

ligi42

ligi commented 8 years ago

and maybe you want to report your issue here : https://github.com/transifex/transifex-client/issues

stephanlindauer commented 8 years ago

will do but let's check if you run into the same issues first you're added btw

ligi commented 8 years ago

Interesting - I am getting the same error in the cm dir - but my projects still work. so it must be a problem how the project is set up - I have the feeling it might be the dash - let's just call it criticalmaps not critical-maps

ligi commented 8 years ago

I am a step further: ⋊> ~/g/3/criticalmaps-android on add_transifex_config ⨯ tx pull
HttpNotFound: Not Found

ligi commented 8 years ago

⋊> ~/g/3/criticalmaps-android on add_transifex_config ⨯ tx push -s 22:44:12 Pushing translations for resource criticalmaps.strings: Pushing source file (app/src/main/res/values/strings.xml) Resource does not exist. Creating... Done. ⋊> ~/g/3/criticalmaps-android on add_transifex_config ⨯ tx pull 22:44:26 Pulling translations for resource criticalmaps.strings (source: app/src/main/res/values/strings.xml) -> fr: app/src/main/res/values-fr/strings.xml Skipping 'ca' translation (file: app/src/main/res/values-ca/strings.xml). -> de: app/src/main/res/values-de/strings.xml -> tr: app/src/main/res/values-tr/strings.xml -> it: app/src/main/res/values-it/strings.xml -> es: app/src/main/res/values-es/strings.xml Done.

ligi commented 8 years ago

ok also pushed the translations - had to create a new resource and delete the old one - we should be all set-up now - please check if tx push / pull now also work for you - but it should - I got the same error message before

stephanlindauer commented 8 years ago

yep works for me! so the issue was the dash and then the missing

type = ANDROID

?

ligi commented 8 years ago

the type was needed for the initial push - not sure if it is needed anymore - but cannot hurt. Also the resource-name was missing behind the project

On 27.09.2016 22:58, stephan lindauer wrote:

yep works for me! so the issue was the dash and then the missing

|type = ANDROID |

?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/criticalmaps/criticalmaps-android/pull/181#issuecomment-249996641, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGz8AmMO4IH0mTwJTAzk21Lv2q7Vx_Eks5quYN3gaJpZM4J_66N.

friendly greetings, ligi http://ligi.de

stephanlindauer commented 8 years ago

should we add the changes of the first tx pull to this pr as well?

stephanlindauer commented 8 years ago

also, is there a way of just exporting the "untranslateable" strings only to the default language? image

ligi commented 8 years ago

not yet sure why there are changes ( only catalan right ?) - also see translatable="false" strings - perhaps we should put them in an extra strings-notranslate.xml file

stephanlindauer commented 8 years ago

yep only catalan, translatable="false" and some minor sorting changes

stephanlindauer commented 8 years ago

strings-notranslate.xml makes sense but we cant add a second default xml file or can we?

ligi commented 8 years ago

sure this works -the content of these xmls get merged

stephanlindauer commented 8 years ago

cool! should this be added to this pr?

ligi commented 8 years ago

updated the PR - with this just seen what ugly german we have in there: Bitte aktivieren deine Internet-Verbindung und starte die App erneut Bitte aktivieren GPS und starte die App erneut

stephanlindauer commented 8 years ago

haha oops :)

cbalster commented 8 years ago

:+1: nice

ligi commented 8 years ago

Interesting - also that this is not breaking the build...

On 28 September 2016 7:40:25 PM GMT+02:00, Christian Balster notifications@github.com wrote:

cbalster commented on this pull request.

@@ -1,12 +0,0 @@ -<?xml version="1.0" encoding="utf-8"?>

-

This is actually used in the design view of chat and twitter

You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/criticalmaps/criticalmaps-android/pull/181#pullrequestreview-1990327

Sent from my Android device with K-9 Mail. Please excuse my brevity.