search

criticalmaps / criticalmaps-android

🤖 Critical Maps Android App
http://criticalmaps.net
Apache License 2.0
136 stars 27 forks source link

[Suggestion] Add version-flavour-git-hash to apk filename #207

Open Wikinaut opened 6 years ago

Wikinaut commented 6 years ago

In another project I used this commit

to add detailed apk information to the apk filename.

In case that you also like this, I can prepare and send a pr for cmaps. Pls. let me know if you are interested.

stephanlindauer commented 4 years ago

not sure i understand this. we currently don't safe apk files (apart from in the play dev console). even for f-droid we just have to tag a new release on github and then they'll build their distributable themselfs.

can you explain what the benefit of this would be?

Wikinaut commented 4 years ago

@stephanlindauer just to see the currently installed version in the apk filename when compiling from the source, in other words: to avoid version problems as developer. I just wanted to help you with some piece of (older) working code.

stephanlindauer commented 4 years ago

as far as i can see it's not something that we would need with the current workflow. wdyt @cbalster?