Observer mode and ui rework

criticalmaps / criticalmaps-android

🤖 Critical Maps Android App

http://criticalmaps.net

Apache License 2.0

136 stars 27 forks source link

Observer mode and ui rework #237

Closed cbalster closed 5 years ago

cbalster commented 5 years ago

adds observer mode (explanation still missing)
updated to the new MaterialComponent theming mechanism and updated colorscheme and layouts

Launch screenshot_1549712035 Intro screenshot_1549712043 Map screenshot_1549712050 Menu screenshot_1549712056 Chat screenshot_1549712070 screenshot_1549712077 Twitter screenshot_1549712087 Rules screenshot_1549712095 screenshot_1549712098 Settings screenshot_1549712102 About screenshot_1549712109 screenshot_1549713493

zutrinken commented 5 years ago

Since I can't test it right now: Why do we need two locate icons? Or what is the left one doing?

cbalster commented 5 years ago

Actionbar title alway shows "Critical Maps" instead of the current view.

Good Point. Even though it's not too uncommon for single activity apps, I think it's better to show the current screen's name.

Since I can't test it right now: Why do we need two locate icons? Or what is the left one doing?

The left one shows map orientation and resets it to north on click. Right one centers location and also acts as a GPS status indicator (normal, searching, gps disabled).

zutrinken commented 5 years ago

I'd give the observer mode a little more context. Some small description and a different icon. A car might be a good choice to point out that's a feature for different types of vehicles:

65634

Or a ghost. That just looks cute:

45232676

cbalster commented 5 years ago

Or a ghost. That just looks cute:

Love the ghost!

I'd give the observer mode a little more context. Some small description and a different icon. A car might be a good choice to point out that's a feature for different types of vehicles:

Yes, that's exactly what I had in mind! Unfortunately the default android NavigationView component doesn't allow for that kind of customization, as the're using a FrameLayout and a RecyclerView with fixed layouts under the hood. This basically means re-writing that part which I will do, but don't really have the time to right now.

cbalster commented 5 years ago

Added an acceptable workaround for adding the description. Not quite happy with the icon on the map though - putting it in a circle would be consistent, but hard to recognize I guess.

cbalster commented 5 years ago

Added icon by @zutrinken

cbalster commented 5 years ago

As soon as you implemented the server side part for observer mode ;) No, I think it would be ideal if the ios and android app both got observer mode at the same time.

I also have another PR that's basically ready, which I will probably push on Tuesday.

stephanlindauer commented 5 years ago

AFAIS the way this will work in the backend is that we will safe the locations of the observers as well but they wont be in the response to the clients, right? if the parameter is not there then we assume non-observer. sounds like relatively simple change to me. i will put this in next weekend.

cbalster commented 5 years ago

Exactly, just a minor change.