Adaptive App Icon - Githubissues

criticalmaps / criticalmaps-android

🤖 Critical Maps Android App

http://criticalmaps.net

Apache License 2.0

136 stars 27 forks source link

Adaptive App Icon #240

Closed zutrinken closed 5 years ago

zutrinken commented 5 years ago

Add Adaptive Icon
Update Launch Screen Logo
Update Logo in Navigation
Update Notification Icon

stephanlindauer commented 5 years ago

i changed the PR base to branch develop
build still fails with
What went wrong: Execution failed for task ':app:processDebugResources'.
Android resource linking failed /home/travis/build/criticalmaps/criticalmaps-android/app/src/main/res/drawable/ic_logo.xml:15: AAPT: error: '#@color/colorSecondary' is incompatible with attribute fillColor (attr) color.

cbalster commented 5 years ago

@zutrinken are you okay with me pushing a commit to this branch fixing the issues mentioned? then we can get this merged an I can add another PR.

cbalster commented 5 years ago

Also we can also get rid of the different dpi versions of ic_launcher_foreground.png by using a single VectorDrawable. This shouldn't be problem since it doesn't have any gradients. If you'd like I can take care of that if you can supply me an .svg or .ai.

zutrinken commented 5 years ago

@cbalster please take over! I'll slack you the .svg

cbalster commented 5 years ago

should be good to go