[Settings] add alternate app icons

criticalmaps / criticalmaps-ios

Critical Maps iOS App 🚲✊

http://www.criticalmaps.net

MIT License

290 stars 41 forks source link

[Settings] add alternate app icons #322

Closed mltbnz closed 4 years ago

mltbnz commented 4 years ago

📝 Docs

[x] Did you update the CHANGELOG.md?

📲 What

Adding a section to the settings to choose an alternate app icon

🤔 Why

For users to customise their app.

👀 See

♿️ Accessibility

~[ ] Tap targets use minimum of 44x44 pts dimensions~
[x] Works with VoiceOver
[x] Supports Dynamic Type

mltbnz commented 4 years ago

@zutrinken I made a simple list to choose. I you have something other in mind we can discuss here maybe

zutrinken commented 4 years ago

Looks legit 👌

mltbnz commented 4 years ago

Is there a specific reason why the alternate app icons are not included in the Images.xcassets? But all in all the code looks good for me and changing the app icon works in my tests in simulator as expected :) Really excited about this feature ;)

So this is the first time I added such a feature and from what I have saw online I think it is not possible to use images from the catalog. But I can take a second look. Maybe there is a way

fbernutz commented 4 years ago

Is there a specific reason why the alternate app icons are not included in the Images.xcassets? But all in all the code looks good for me and changing the app icon works in my tests in simulator as expected :) Really excited about this feature ;)

So this is the first time I added such a feature and from what I have saw online I think it is not possible to use images from the catalog. But I can take a second look. Maybe there is a way

Ah okay, I've never implemented this myself as well, so I have no idea... 😄 When it's not working with asset catalog, it's fine for me like this as well.