search

criticalmaps / criticalmaps-ios

Critical Maps iOS App 🚲✊
http://www.criticalmaps.net
MIT License
287 stars 41 forks source link

Improve VoiceControl support #330

Closed ghost closed 3 years ago

ghost commented 3 years ago

📝 Docs

📲 What

Improvement of VoiceControl support

🤔 Why

Issue #263

mltbnz commented 3 years ago

Thanks for your PR. I am very sad that the Greetings step in the CI failed because it should have said something like: "Hello and thanks for your contribution"... Need to check that.

Regarding your PR: I did not know accessibilityUserInputLabels and first had to check it out. Is it the case that it adds additional description to a e.g. label and are they used in addition to accessibiltyLabel?

Regarding the lokalizable changes: I think they are good but we started using a service to manage: https://crowdin.com/project/critical-maps Maybe you could also update them there? It is not automated yet and I manually have to download the strings files and add them to the repo. Maybe as a contributor that also works

fbernutz commented 3 years ago

Thanks again for the contribution! Could you please resolve the conversations (you can also commit the suggestions) and rebase your branch with master? Then we could merge this 🎉

ghost commented 3 years ago

Thanks for your PR. I am very sad that the Greetings step in the CI failed because it should have said something like: "Hello and thanks for your contribution"... Need to check that.

Regarding your PR: I did not know accessibilityUserInputLabels and first had to check it out. Is it the case that it adds additional description to a e.g. label and are they used in addition to accessibiltyLabel?

Regarding the lokalizable changes: I think they are good but we started using a service to manage: https://crowdin.com/project/critical-maps Maybe you could also update them there? It is not automated yet and I manually have to download the strings files and add them to the repo. Maybe as a contributor that also works

Hi, Malte

As far as I know, the accessibilityUserInputLabels are only used in VoiceControl, when someone says any of the labels on the array the VoiceControl assumes it is about that element the person is talking about, accessibiltyLabel is used on VoiceOver.

Also, I'll try to update the lokalizable changes on crowdin. 😊