Fix some visual appearances

criticalmaps / criticalmaps-ios

Critical Maps iOS App 🚲✊

http://www.criticalmaps.net

MIT License

287 stars 41 forks source link

Fix some visual appearances #364

Closed mltbnz closed 3 years ago

mltbnz commented 3 years ago

Need to fix accessory color

Need to fix appearance for text input

under iOS 12 the event marker is wrongly tinted

besilva commented 3 years ago

Can I take this issue? @mltbnz

besilva commented 3 years ago

Where can I check the correct appearance for text input? Does the team use Figma or some other design tool?

besilva commented 3 years ago

Nvm I found https://github.com/criticalmaps/criticalmaps-design

mltbnz commented 3 years ago

Where can I check the correct appearance for text input? Does the team use Figma or some other design tool?

The Text Input should behave like an OS one would I would say. I fear its appearance is set in one of the ThemeController selector calls which grew a little bit out of control. But looks like it's fixed in your PR?!

mltbnz commented 3 years ago

The bug only appears in the light version

besilva commented 3 years ago

I think it's ok now with my PR