criticalmaps / criticalmaps-ios

Critical Maps iOS App 🚲✊
http://www.criticalmaps.net
MIT License
287 stars 41 forks source link

Make BikeAnnotationView more accessible #368

Closed besilva closed 3 years ago

besilva commented 3 years ago

📝 Docs

📲 What

Now Bike Annotation scales with preferredContentSizeCategory

🤔 Why

This way the view is easier to see for people who use their device with larger texts Also I changed the way the view is created because it was creating a Optimization Opportunity like in the image below

Screen Shot 2020-11-14 at 03 15 22

👀 See

Screenshots, external resources?

Before 🐛 After 🦋
default IMG_1998 IMG_1998
extra large IMG_1998 IMG_1999
large IMG_1998 IMG_2001
small IMG_1998 IMG_2002

♿️ Accessibility

besilva commented 3 years ago

242 I think the design should give some feedback about the sizes and also I didn't know what to put on Changelog.

mltbnz commented 3 years ago

Also really cool you fixed the optimization opportunity! 🚀

besilva commented 3 years ago

@mltbnz Thanks a lot! I think the idea of use the feedback to improve this feature is perfect.

besilva commented 3 years ago

Updated Changelog but I'm not sure if it was in the right place hehe