minor layout fixes

[besilva]

📝 Docs

• [x] Did you update the CHANGELOG.md?

📲 What

Fix some layout issues found by @mltbnz

🤔 Why

Our chat input was different from layout and acessory item color was hard to sse

👀 See

Screenshots, external resources?

• [x] Added snapshot tests (using iPhone 8 Simulator)

Before 🐛	After 🦋

♿️ Accessibility

• [x] Tap targets use minimum of 44x44 pts dimensions
• [x] Works with VoiceOver
• [x] Supports Dynamic Type

[besilva]

364 Couldn't reproduce the problem with the event marker here :(

[besilva]

@mltbnz about the layout changes on the chat input, do you think the button should stick to the top when the textView grows? I can change to make it stick to the middle or the bottom

[mltbnz]

@besilva probably it makes sense to lay out the button on the bottom like in e.g. messages does. Wdyt?

[besilva]

@mltbnz makes sense to me. Similar approach to native UI makes easier for the user also in the bottom option it's near from the keyboard so it is easier to reach the button. Just made the update:

[mltbnz]

Cool. Also that the button now is inside the view 👍

[besilva]

I followed the design from the design repo. Thanks a lot for the approve and hope I can contribute more @mltbnz

[besilva]

Another thing is the changelog, should I create another version there or use the last one created?

[mltbnz]

Another thing is the changelog, should I create another version there or use the last one created?

I think it's best to start a new version there with a headline ## [Unreleased] the project refers to https://keepachangelog.com/en/1.0.0/ where you also find examples.

[fbernutz]

Oh didn't see the discussion here :) I've added a new Unreleased section on master, so just add it there. 🙏

[fbernutz]

The changes look good for me, but I'm still wondering why the snapshot test for AppSettingsVC didn't caught the tint color bug. Anyone an idea?

[mltbnz]

The changes look good for me, but I'm still wondering why the snapshot test for AppSettingsVC didn't caught the tint color bug. Anyone an idea?

I was also wondering 💭 but maybe the change is too subtle and is within the acceptable error margin 🤷‍♂️

[fbernutz]

The changes look good for me, but I'm still wondering why the snapshot test for AppSettingsVC didn't caught the tint color bug. Anyone an idea?

I was also wondering 💭 but maybe the change is too subtle and is within the acceptable error margin 🤷‍♂️

Mh, I've changed the precision from 99% to 100% again but the bug is still not caught. 🤔 Maybe it has something to do with the MockThemeController logic which is used in the snapshot test? -- edit: but I can't reproduce the bug with the missing tint color on the settings on the appstore version as well 🤔

[mltbnz]

The changes look good for me, but I'm still wondering why the snapshot test for AppSettingsVC didn't caught the tint color bug. Anyone an idea?

I was also wondering 💭 but maybe the change is too subtle and is within the acceptable error margin 🤷‍♂️

Mh, I've changed the precision from 99% to 100% again but the bug is still not caught. 🤔 Maybe it has something to do with the MockThemeController logic which is used in the snapshot test?

-- edit: but I can't reproduce the bug with the missing tint color on the settings on the appstore version as well 🤔

Now I also can't. Either something is messed up or I got a really buggy version that crashes and presents me visual errors. because it can 🤷‍♂️😁

[besilva]

Another thing is the changelog, should I create another version there or use the last one created?

I think it's best to start a new version there with a headline ## [Unreleased] the project refers to https://keepachangelog.com/en/1.0.0/ where you also find examples.

I was wondering if you guys would create a new Unreleased or I should do it. That's why i asked here

[besilva]

The changes look good for me, but I'm still wondering why the snapshot test for AppSettingsVC didn't caught the tint color bug. Anyone an idea?

I was also wondering 💭 but maybe the change is too subtle and is within the acceptable error margin 🤷‍♂️

Mh, I've changed the precision from 99% to 100% again but the bug is still not caught. 🤔 Maybe it has something to do with the MockThemeController logic which is used in the snapshot test? -- edit: but I can't reproduce the bug with the missing tint color on the settings on the appstore version as well 🤔

Now I also can't. Either something is messed up or I got a really buggy version that crashes and presents me visual errors. because it can 🤷‍♂️😁

This is a guess: Maybe it is a iOS 14.1 bug, because I could see the problem in both simulator and my device but I did not look which version of iOS we use in the CI

[fbernutz]

The changes look good for me, but I'm still wondering why the snapshot test for AppSettingsVC didn't caught the tint color bug. Anyone an idea?

I was also wondering 💭 but maybe the change is too subtle and is within the acceptable error margin 🤷‍♂️

Mh, I've changed the precision from 99% to 100% again but the bug is still not caught. 🤔 Maybe it has something to do with the MockThemeController logic which is used in the snapshot test? -- edit: but I can't reproduce the bug with the missing tint color on the settings on the appstore version as well 🤔

Now I also can't. Either something is messed up or I got a really buggy version that crashes and presents me visual errors. because it can 🤷‍♂️😁

This is a guess: Maybe it is a iOS 14.1 bug, because I could see the problem in both simulator and my device but I did not look which version of iOS we use in the CI

Interesting, we're currently still using Xcode 12.0 in the CI, so the tests run on iOS 14.0. (https://github.com/criticalmaps/criticalmaps-ios/blob/master/.github/workflows/main.yml#L20) I can't reproduce the tint color bug in the simulator with iOS 14.1 and 14.2, also not on my own device with iOS 14.2.

But I think we can merge this nevertheless. ✌️

[mltbnz]

When setting the theme to light, then kill the app and open again I was able to reproduce it. If you then switch to system or dark theme and back to light the tint is fine. Not that big of a deal for now

[fbernutz]

When setting the theme to light, then kill the app and open again I was able to reproduce it. If you then switch to system or dark theme and back to light the tint is fine. Not that big of a deal for now

Interesting... even with that instruction, I'm not able to reproduce the bug in the current AppStore version.

[mltbnz]

When setting the theme to light, then kill the app and open again I was able to reproduce it. If you then switch to system or dark theme and back to light the tint is fine. Not that big of a deal for now

Interesting... even with that instruction, I'm not able to reproduce the bug in the current AppStore version.

Ok. Getting too crazy for me 😛 Let's merge then and next time ship your version 😁