criticalmaps / criticalmaps-ios

Critical Maps iOS App 🚲✊
http://www.criticalmaps.net
MIT License
287 stars 41 forks source link

Adapt BikeAnnotationSize to equal the Sizes in Maps #377

Closed fbernutz closed 3 years ago

fbernutz commented 3 years ago

📝 Docs

📲 What

Adapt the Bike Annotation Size to be equal the sizes in Maps. All Dynamic Type Sizes are now supported and you can test this in Xcode with the Environment Overrides Menu by activating Dynamic Type.

🤔 Why

Currently, there are some jumps in the size when the dynamic type gets higher.

👀 See

Sadly Github doesn't support videos in PR descriptions, so here are some example Screenshots.

Before L 🐛 After L 🦋
Screen Shot 2020-12-06 at 15 25 34 Screen Shot 2020-12-06 at 15 24 41
Before XL 🐛 After XL 🦋
Screen Shot 2020-12-06 at 15 23 47 Screen Shot 2020-12-06 at 15 24 22
Before XXL 🐛 After XXL 🦋
Screen Shot 2020-12-06 at 15 27 29 Screen Shot 2020-12-06 at 15 28 48
Before XXXL 🐛 After XXXL 🦋
Screen Shot 2020-12-06 at 15 27 37 Screen Shot 2020-12-06 at 15 28 53

♿️ Accessibility