[Events feature] add ride `enabled` parameter - Githubissues

criticalmaps / criticalmaps-ios

Critical Maps iOS App 🚲✊

http://www.criticalmaps.net

MIT License

287 stars 41 forks source link

[Events feature] add ride `enabled` parameter #390

Closed mltbnz closed 3 years ago

mltbnz commented 3 years ago

📝 Docs

[x] Did you update the CHANGELOG.md?

📲 What

Add enabled parameter to ride object. https://github.com/criticalmass-one/criticalmass-in/blob/19251cdcea9db966a5e411c8a058d7a04aa92c7f/src/Entity/Ride.php#L315
Make RideManager check if the "nextRide" is enabled and otherwise do not save it as the next ride
save nextRide it is enabled but does not have an eventType set. Might happen since the API is not 💯

🤔 Why

we do not want to show cancelled events.
rides without eventType were showing on the map as an annotation and also the event banner is shown but tapping on it did not focus the next event since it was not set in the 'RideManager'. Coming back to the codebase after 3 months (even 3 months of not coding this feels weird... but 🤷‍♂️)