[4.0] Links from tweets can be tapped and will open the URL

criticalmaps / criticalmaps-ios

Critical Maps iOS App 🚲✊

http://www.criticalmaps.net

MIT License

283 stars 40 forks source link

[4.0] Links from tweets can be tapped and will open the URL #425

Closed mltbnz closed 2 years ago

mltbnz commented 2 years ago

For the 4.0.0 version

In the twitter feature currently a tap on a tweet will open the tweet URL but It would be nice if a link is inside the tweet and users tap on it, if that link itself would be opened as well

deltarfd commented 2 years ago

I think this issue is running fine in an already running application and there is no problem, or am I missing the error?

mltbnz commented 2 years ago

You are correct. I am working on version 4 which is happening on branch develop and which will be a SwiftUI implementation of the app with a couple updates. That is where that feature is currently not working.

Can I ask for your opinion about that specific feature like do you think it should make it to 4.0? Do you use it? I felt that most of the links are other tweets and the benefit of having it wasn't really there for me.

Twitter feature branch #424