critiqjo / key-mon

Automatically exported from code.google.com/p/key-mon
https://github.com/scottkirkwood/key-mon
Apache License 2.0
97 stars 8 forks source link

Several features seem to be sticky #57

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. key-mon --swap
or
2. key-mon --theme=apple

Please provide any additional information below.
In case 1.), swap never goes off in subsequent calls of key-mon, even when 
calling
key-mon --noswap
So it seems that
a) the feature is sticky, i.e. being cached/stored somewhere (even across GNOME 
sessions), and I can't figure out where,
b) --noswap has no effect.

In case 2.), I can still choose a different theme such as "oblivion" or 
"modern" if installed, but
a) key-mon defaults to "apple", even when no theme is given
b) key-mon can't go back to "classic", even with "--theme=classic".

This is both peculiar and annoying.

Original issue reported on code.google.com by mbst...@googlemail.com on 20 Sep 2010 at 2:15

GoogleCodeExporter commented 9 years ago
Agreed, it is annoying.

The configuration lives in ~/.config/key-mon/config, deleting that file will 
bring you back to the default (in the meantime).

I'll work on testing and fixing the --noswap style parameters.

Original comment by scottaki...@gmail.com on 20 Sep 2010 at 2:33

GoogleCodeExporter commented 9 years ago
Thanks, I hadn't figured out "~/.config/key-mon/config". It's probably 
documented. :-)

Yes, deleting works for me.

The sticky opts may or may not be a feature, personally, I don't like it. ;-) 
(w3m behaves similarly, other programs usually don't.) But it ills on the fact 
that there are some --no switches missing, like --nolarge. Or am I wrong? (I 
saw the scale 1.25 in that file, which I had only ever passed once.)

Thanks!

Original comment by mbst...@googlemail.com on 20 Sep 2010 at 2:54

GoogleCodeExporter commented 9 years ago
Originally, there was only command line parameters and they weren't sticky.
Then a patch came it to make them all sticky.
Now I've added an options page where stickiness makes some sense (and the 
command line parameters are starting to make less sense).
For now I'm going to leave it the way it is (sticky command line parameters) 
but I'm adding a --reset go bring everything back to defaults.

Original comment by scottaki...@gmail.com on 20 Sep 2010 at 3:04

GoogleCodeExporter commented 9 years ago
Sounds perfect so far. Thanks!

Original comment by mbst...@googlemail.com on 20 Sep 2010 at 3:08

GoogleCodeExporter commented 9 years ago
The fix you introduced in 1.4.1 does work around this issue. But the whole 
thing is still cludgy. That's why I don't like the sticky feature. :) (That's a 
matter of taste of course.)

a) key-mon --reset --theme=oblivion
   will not display the oblivion theme
b) key-mon --reset
   will reset the settings, but still execute key-mon. So to use (e.g.)
   the oblivion theme, I need to 
   key-mon --reset
   Ctrl+C
   key-mon --theme=oblivion
c) And even then if I only wanted to change the theme, I have reset
   all other config file options.

As I said, it's not a bug, it's just a usability thing. I understand that 
mixing config file settings and command line options is tricky.

I would usually understand a command line option as: "Please do this." That's 
why it startles you if it doesn't behave that way.

Perhaps a suggestion is:
a) Handle config files for defaults.
b) Prefer command line settings over defaults.
c) Offer a command line option to store the given config (file+cmdline) as
   new default.
c1) Need to figure out whether to keep stuff in the file not specified on
    the command line; or
c2) Offer a command line option for everything to be able to reverse the
    config file setting.

Or something along these lines. And perhaps:
d) Keep the "--reset" option just for ease of use. :-)

Just a suggestion! :-)

Original comment by mbst...@googlemail.com on 22 Sep 2010 at 2:06

GoogleCodeExporter commented 9 years ago

Original comment by scottaki...@gmail.com on 23 Sep 2010 at 12:55