change parent for <uses-permission>

crittercism / PhoneGap

Other

7 stars 15 forks source link

Closed vipulkrsingh closed 9 years ago

vipulkrsingh commented 9 years ago

When doing cordova build --release android
Following error was thrown "The element must be a direct child of the root element [WrongManifestParent]"
This happened after updating cordova(5.0.0) and android sdk ( Revision 24.2.0 ) .

dshirley commented 9 years ago

Thanks for making this change!

fh commented 9 years ago

@dshirley Is there an ETA when this will be merged? I am currently having the same problem with cordova 5.0 and this plugin :)

jfrumar commented 9 years ago

I'm waiting too - please merge

vipulkrsingh commented 9 years ago

@dshirley i think both parent="/*" and parent="/manifest/application" are correct.
Only that i found other phoneGap plugins using parent="/*" e.g (phonegap-facebook-plugin)[https://github.com/Wizcorp/phonegap-facebook-plugin/blob/master/plugin.xml] so decided to go with that..

dshirley commented 9 years ago

@vipulkrsingh Thanks for the response.

LGTM