Agnt 1398 App ID - Githubissues

crittercism / PhoneGap

Other

7 stars 15 forks source link

Agnt 1398 App ID #22

Closed vlukman closed 8 years ago

vlukman commented 8 years ago

Enhancement for https://crittercism.atlassian.net/browse/AGNT-1398

WORK DONE

Added a PhoneGap method Crittercism.init(appID)
Removed required IOS_APP_ID and ANDROID_APP_ID when installing PhoneGap plugin

TEST

Installed plugin with the following command: cordova -d plugin add https://github.com/crittercism/PhoneGap#AGNT-1398-appID
Called Crittercism.init(appID) on javascript

TEST RESULT

App runs normally on iOS and Android without crash. Crittercism SDK was initialized normally.

@dshirley Please review @sforen Please be very strict with my Java code

dshirley commented 8 years ago

Looks good. Couple minor comments.