search

crittermike / shortkeys

A browser extension for custom keyboard shortcuts
https://www.shortkeys.app/
Other
1k stars 159 forks source link

Use userScripts API for JavaScript actions #633

Closed tjhorner closed 2 months ago

tjhorner commented 3 months ago

This fixes #599.

The implementation is mostly complete (if a bit sloppy), but there is one missing piece: as part of this change, IDs for each shortcut are introduced. Shortcuts with missing IDs will be added on next save. This means users will need to go to the config page at least once before their JS shortcuts will work.

It's possible to perform this migration on extension update but I'm not sure how you wanted to go about it.

hababr commented 2 months ago

@tjhorner Nice fix, thank you. After building a release for Chrome I had to fix service_worker.js, a function name was missing (registerHandlers).

niksumeiko commented 1 month ago

@crittermike, when do you plan to publish a new release with this fix? I still see 4.1.3 from May in https://github.com/crittermike/shortkeys/releases

crittermike commented 1 month ago

@niksumeiko https://github.com/crittermike/shortkeys/issues/621#issuecomment-2284115958

tjhorner commented 1 month ago

@tjhorner Nice fix, thank you. After building a release for Chrome I had to fix service_worker.js, a function name was missing (registerHandlers).

Ahh, the name was minified wasn't it? Nice catch

hababr commented 1 month ago

@tjhorner Yes, right. I'm going to create a PR to fix that and to add missing IDs upon update. Or may be you would like to do that?