search

crittermike / shortkeys

A browser extension for custom keyboard shortcuts
https://www.shortkeys.app/
Other
1.02k stars 161 forks source link

Deleting a shortcut also deletes the row with the same shortcut key #642

Open Zankio opened 1 month ago

Zankio commented 1 month ago

When deleting the first shortcut, the second one is also deleted. Eample

  1. Shortcut a for site A
  2. Shortcut a for site B
Susko3 commented 1 day ago

Relevant code:

https://github.com/crittermike/shortkeys/blob/83750b29091aed50f04af05f384a1bb3f61ca64a/app/options/options.vue#L253-L256

Should probably be changed to regular reference equality, if that works:

-                onConfirm: () => this.keys = this.keys.filter(curKey => key.key !== curKey.key)
+                onConfirm: () => this.keys = this.keys.filter(curKey => key !== curKey)